Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a comprehensive admin feature set including an admin domain, admin authentication, and admin-facing APIs for managing organizations, users, and articles.
Key Changes
- Admin Domain & Authentication: New admin entity and auth-admin modules with registration and login capabilities
- Password Hasher Refactoring: Moved PasswordHasher from auth-organization to shared auth-core module for reuse across authentication contexts
- Cursor-Based Pagination: Implemented paginated list endpoints for organizations, users, and articles accessible to admin users
- Organization Withdrawal: Added functionality for organizations to delete their accounts along with associated authentication data
Reviewed changes
Copilot reviewed 86 out of 88 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
src/shared/exception/custom-exception-code.ts |
Added admin and auth-admin exception codes; renamed password validation error to be auth-context agnostic |
src/shared/core/presentation/admin.decorator.ts |
New decorator for extracting admin payload from JWT tokens |
src/article/query/organization/presentation/article.view.controller.ts |
Added admin article controller with endpoints for listing and viewing articles |
src/article/query/organization/infrastructure/* |
Added cursor-based pagination support and article summary mapping |
src/article/query/organization/domain/* |
Added ArticleSummaryModel and reader methods for admin queries |
iam/user/* |
Added admin user controller and cursor-based pagination for user listings |
iam/organization/* |
Added admin organization controller, cursor pagination, and updated create/delete use cases |
iam/auth/auth-organization/* |
Refactored registration to use shared password hasher; added withdrawal functionality |
iam/auth/auth-core/* |
Centralized PasswordHasher interface and implementation for reuse |
iam/auth/auth-admin/* |
New auth-admin module with registration, login, and logout for admin users |
iam/admin/* |
New admin domain with repository, entity, and use cases for admin management |
Comments suppressed due to low confidence (3)
iam/auth/auth-organization/application/register-organization/register-organization.use-case.ts:22
- There is a typo in the variable name 'createOrganiationUseCase' - it should be 'createOrganizationUseCase' (missing 'z' in 'Organization').
iam/auth/auth-core/infrastructure/bcrypt/password-hasher.impl.ts:2 - The import path uses a relative path with '../domain/password-hasher' instead of using the centralized location 'iam/auth/auth-core/domain/password-hasher'. This is inconsistent with the refactored architecture where PasswordHasher has been moved to auth-core. The import should be updated to match the new location.
iam/auth/auth-organization/application/register-organization/register-organization.use-case.ts:62 - There is a typo in the variable name 'createOrganiationUseCase' - it should be 'createOrganizationUseCase' (missing 'z' in 'Organization').
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iam/auth/auth-admin/presentation/dto/request/register-admin.request.dto.ts
Show resolved
Hide resolved
iam/organization/application/get-all/get-all-organizations.use-case.ts
Outdated
Show resolved
Hide resolved
src/article/query/organization/application/article-summary/get-article-summaries.use-case.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용