[WIP] Fix senate #25
Open
[WIP] Fix senate #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the House and Governors' races.
whereistanya
requested changes
Oct 9, 2016
Contributor
whereistanya
left a comment
whereistanya
left a comment
There was a problem hiding this comment.
Is the ipython notebook file a step along the way, or the final product?
I suggest you send the test fixes as a PR on their own, so we can get that committed.
| for k in cases: | ||
| self.assertEqual(candidate.normalize_name(k), cases[k]) | ||
|
|
||
| @pytest.mark.skip(reason="candidate.check_field has been removed") |
Contributor
There was a problem hiding this comment.
Just rip the test out instead, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A start to fixing candidatebot to work for Senate races.
Re https://devprogress.slack.com/archives/proj-candidatebot/p1475791952000002:
Current status: tests fixed and I have a Jupyter notebook to write a CSV.