feat(dgw): add CredSSP certificate configuration keys#1676
Merged
Benoît Cortier (CBenoit) merged 1 commit intomasterfrom Feb 17, 2026
Merged
feat(dgw): add CredSSP certificate configuration keys#1676Benoît Cortier (CBenoit) merged 1 commit intomasterfrom
Benoît Cortier (CBenoit) merged 1 commit intomasterfrom
Conversation
Copilot started reviewing on behalf of
Benoît Cortier (CBenoit)
February 13, 2026 17:16
View session
Richard Markiewicz (thenextman)
approved these changes
Feb 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring a separate certificate for CredSSP credential injection, allowing operators to use a different certificate than the main TLS certificate when performing proxy-based RDP credential injection. When the new configuration options are not set, the gateway falls back to using the existing TLS certificate, ensuring backward compatibility.
Changes:
- Added
CredSspCertificateFileandCredSspPrivateKeyFileconfiguration options - Updated configuration schema and documentation to reflect the new options
- Modified RDP proxy and clean path handlers to use the CredSSP certificate when available, falling back to TLS certificate
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| devolutions-gateway/src/config.rs | Added credssp_tls field and initialization logic for CredSSP-specific certificates |
| devolutions-gateway/src/rdp_proxy.rs | Updated to use credssp_tls with fallback to tls |
| devolutions-gateway/src/rd_clean_path.rs | Updated to use credssp_tls with fallback to tls |
| devolutions-gateway/tests/config.rs | Added new fields to all test configuration samples |
| config_schema.json | Added JSON schema definitions for the new configuration options |
| README.md | Documented the new configuration options with usage guidelines |
| docs/COOKBOOK.md | Added note about optional CredSSP certificate configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Benoît Cortier (CBenoit)
force-pushed
the
feat/config-keys-for-credssp
branch
from
482a72f to
9e7e002
Compare
Add optional `CredSspCertificateFile` and `CredSspPrivateKeyFile` configuration keys allowing usage of a different certificate for CredSSP credential injection instead of the main TLS certificate. When unset, the existing TLS certificate is used (no behavior change).
Benoît Cortier (CBenoit)
force-pushed
the
feat/config-keys-for-credssp
branch
from
9e7e002 to
1fa0e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
CredSspCertificateFileandCredSspPrivateKeyFileconfiguration keys allowing usage of a different certificate for CredSSP credential injection instead of the main TLS certificate. When unset, the existing TLS certificate is used (no behavior change).