fix: Use find_device from device endpoint #1315
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
=======================================
Coverage 94.99% 95.00%
=======================================
Files 42 42
Lines 2759 2761 +2
=======================================
+ Hits 2621 2623 +2
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpoliaw
changed the title
Using the find_device method instead of looking devices up in the map of devices directly means child devices can be found, eg 'stage.x' could be a valid device but isn't in the devices map in its own right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the find_device method instead of looking devices up in the map of
devices directly means child devices can be found, eg 'stage.x' could be
a valid device but isn't in the devices map in its own right.
There is still a bit of weirdness as querying
/devices/stage.xwill return aDeviceModelwith a name ofstage-xbut querying forstage-xwillfail with a 404.
Relates to #903 and #1137.