chore(deps): Remove pyright version cap #1329
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can scanspec PR be merged before this ? |
abbiemery
approved these changes
Jan 13, 2026
Contributor
abbiemery
left a comment
abbiemery
left a comment
There was a problem hiding this comment.
The scanspec pr has now been merged (bluesky/scanspec#197)
Version 1.1.407 had a bug (microsoft/pyright/issues/11060) in handling pydantic models. Now 1.1.408 is available with a fix, we can exclude the specific version and accept newer versions as they're released.
tpoliaw
force-pushed
the
pyright-version
branch
from
0334f58 to
1a6aa46
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1329 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 42 42
Lines 2755 2755
=======================================
Hits 2617 2617
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I'm guessing we can merge this without there being a scanspec release? The two version specifiers should be compatible, it'll just carry on choosing 1.1.406 until the new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.1.407 had a bug (microsoft/pyright/issues/11060) in handling
pydantic models. Now 1.1.408 is available with a fix, we can exclude the
specific version and accept newer versions as they're released.