Skip to content

Conversation

@dan-fernandes
Copy link
Contributor

Minor logging issue that messes with formatters

@dan-fernandes dan-fernandes requested a review from a team as a code owner January 14, 2026 10:47
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (d89b366) to head (732090f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1335   +/-   ##
=======================================
  Coverage   94.99%   95.00%           
=======================================
  Files          42       42           
  Lines        2759     2762    +3     
=======================================
+ Hits         2621     2624    +3     
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dan-fernandes dan-fernandes changed the title Replace logging.info with LOGGER.info fix: Replace logging.info with LOGGER.info Jan 14, 2026
tpoliaw
tpoliaw previously approved these changes Jan 14, 2026
@ZohebShaikh
Copy link
Contributor

It can be fixed in some other place as well

  1. numtracker
  2. In the scratch file there are some more logging
  3. In cli.py here
  4. In Docs

@tpoliaw tpoliaw dismissed their stale review January 14, 2026 12:03

Might need further changes

@dan-fernandes
Copy link
Contributor Author

Good spot - the other instances of "direct logging" have been addressed

@dan-fernandes dan-fernandes merged commit 7922683 into main Jan 15, 2026
17 checks passed
@dan-fernandes dan-fernandes deleted the scratch-logging-issue branch January 15, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants