Open
Conversation
JamesOHeaDLS
left a comment
JamesOHeaDLS
left a comment
There was a problem hiding this comment.
This will be a cool feature!
Code looks good. Only a couple of suggestions from me
|
0 isn't a valid ssh port number. The check will need to be from 1 to 65535 |
LeandroMartinsdS
force-pushed
the
150-expose-powerpmac-ssh-port
branch
from
fd147c3 to
e136352
Compare
Contributor
Author
|
Any suggestion about documentation format and where to keep it? |
|
I think the documentation should live inside the pmac repo so it is available for anyone who clones the driver. I see there is already a docs folder. I would keep the instructions in markdown as this is accessible without requiring other software to read it |
LeandroMartinsdS
force-pushed
the
150-expose-powerpmac-ssh-port
branch
from
e136352 to
ea0de46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose the SSH port used for communication between the pmac driver and the PowerPMAC controller to support simulator-based development.
Motivation
Developing and debugging the pmac driver currently requires access to physical PowerPMAC hardware. By exposing the SSH port, developers can connect the driver to a virtual PowerPMAC instance running in the PowerPMAC simulator. This makes it possible to test and iterate on driver features in a more flexible and accessible environment.
Changes
Next Steps
Instructions for using the driver with the simulator to be added.