Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new LPC CUDA kernel implementation and updates related recurrence functions to leverage both CUDA and CPU runners. Key changes include refactoring the recurrence functions to use lambdas for kernel dispatching, adding CUDA kernel implementations in C++ under torchlpc/csrc/cuda/lpc.cu, and extending test coverage to include additional sample sizes and device options.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| torchlpc/recurrence.py | Updated recurrence functions to choose between CUDA and CPU runners via lambdas. |
| torchlpc/csrc/cuda/lpc.cu | Added new CUDA kernels for LPC computation including support for complex types. |
| torchlpc/core.py | Adjusted LPC forward logic to conditionally dispatch based on EXTENSION_LOADED. |
| tests/test_extension.py | Expanded test parameters for sample sizes and devices (CPU/CUDA) for LPC equivalence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The results on a 5060 ti GPU with linux machine:
Don't know why, but the .cu version is significantly faster.