MacOS App: Integrated WebGPUView#263
MacOS App: Integrated WebGPUView#263MikhailGorobets wants to merge 2 commits intoDiligentGraphics:masterfrom
Conversation
| @@ -0,0 +1,87 @@ | |||
| /* | |||
There was a problem hiding this comment.
ImGui changes seem to be unrelated to WebGPU on Mac?
There was a problem hiding this comment.
Didn’t want to create a separate PR(we can use rebase instead squash). On macOS, ImGui runs into an issue when using ImIO.Fonts->AddFontFromFileTTF, since internally it uses fopen.
There was a problem hiding this comment.
This needs to be submitted separately - we need to merge this into development first and then try to build the main module to make sure all tests pass since it affects all platforms.
| @@ -0,0 +1,87 @@ | |||
| /* | |||
There was a problem hiding this comment.
This needs to be submitted separately - we need to merge this into development first and then try to build the main module to make sure all tests pass since it affects all platforms.
| namespace Diligent | ||
| { | ||
|
|
||
| #if PLATFORM_WIN32 | ||
| class WindowsFile; | ||
| using ImGuiFile = WindowsFile; | ||
| #elif PLATFORM_UNIVERSAL_WINDOWS | ||
| class WindowsStoreFile; | ||
| using ImGuiFile = WindowsStoreFile; | ||
| #elif PLATFORM_ANDROID | ||
| class AndroidFile; | ||
| using ImGuiFile = AndroidFile; | ||
| #else | ||
| class StandardFile; | ||
| using ImGuiFile = StandardFile; | ||
| #endif | ||
|
|
||
| } // namespace Diligent |
There was a problem hiding this comment.
There is CFile that is exactly that.
https://github.com/DiligentGraphics/DiligentCore/blob/ce4e9b10ee7c9c603882fb6b89d622f5a5941823/Platforms/interface/FileSystem.hpp#L62-L90
| * of the possibility of such damages. | ||
| */ | ||
|
|
||
| #include "ImGuiDiligentConfig.h" |
There was a problem hiding this comment.
I don't think ImGuiDiligentConfig.h is helpful (unless it needs to be included somewhere else).
The function definitions can be added right in the source file here - it will be cleaner
2 participants
No description provided.