Output results as a dataframe + return short names, hctsa names and values as standard.#31
Open
joshuabmoore wants to merge 8 commits intomainfrom
Open
Output results as a dataframe + return short names, hctsa names and values as standard.#31joshuabmoore wants to merge 8 commits intomainfrom
joshuabmoore wants to merge 8 commits intomainfrom
Conversation
Collaborator
Author
|
Also, the changelogs will be more extensive and clearer about the breaking changes for users + new naming conventions with old short_names and names essentially swapping places. |
Contributor
|
@anniegbryant can you do a quick test? |
|
I tried the new catch22_all function with my workflow. The change in the dictionary/dataframe key from 'values' (old version) to 'value' (new version) breaks my code. Otherwise, it works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying the original changes proposed by @anniegbryant in PR #21, this PR updates the catch22 output to a DataFrame and marks a transition away from long (HCTSA) feature names toward what has previously been called "short" feature names, as default, i.e.,
mode_5instead ofDN_HistogramMode_5, etc.Breaking Changes:
Since these modifications will introduce breaking changes for the existing user base, this PR will constitute a new major version release (catch22
v1.0.0), with docs + README updated to reflect the new output format. Users will need to be made aware of the new output via clear documentation and a migration guide in the changelogs to avoid confusion.Major changes
short_namesas an optional parameter in thecatch22_all()function. Three columns will now be returned as standard:feature,hctsa_nameandvalue. That is,catch22_all()now accepts only two arguments:< = v0.4.5catch22features_shortare now calledfeatures(orfeaturein the output DataFrame).< = v0.4.5catch22featureis nowfeatures_hctsa(orhctsa_namein the output DataFrame).catch22results are now returned as a pandasDataFrameinstead of adictfor improved readability:pandasandnumpydependencies.Minor changes
SECURITY.md.CODE_OF_CONDUCT.mdDataFrameoutput.3.12unit test runners.DataFrameoutput.