Skip to content

Conversation

@jajhall
Copy link
Member

@jajhall jajhall commented Jan 29, 2026

This page will be correct when cuPDLP-C is replaced by HiPDLP, and the QP IPM solver is added, so this is just a draft PR

@jajhall jajhall requested a review from filikat January 29, 2026 17:22
@jajhall
Copy link
Member Author

jajhall commented Jan 29, 2026

Closes #2781

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.32%. Comparing base (382c51e) to head (facd1d7).
⚠️ Report is 19 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2787   +/-   ##
=======================================
  Coverage   80.31%   80.32%           
=======================================
  Files         348      348           
  Lines       86093    86095    +2     
=======================================
+ Hits        69148    69156    +8     
+ Misses      16945    16939    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall
Copy link
Member Author

jajhall commented Jan 29, 2026

Closes #2752

Copy link
Collaborator

@filikat filikat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In definitions.md for option solver, should there be both "pdlp" and "hipdlp"? The option for "pdlp" should also coincide with what is used in the Summary of solvers.md.
It seems like you removed the statements "Setting the solver option to ... forces the ... solver to be used" from the LP section, since they are now present in the summary. But they still appear in the QP section. For consistency, it may be better to remove them from there as well.

@jajhall
Copy link
Member Author

jajhall commented Jan 30, 2026

In definitions.md for option solver, should there be both "pdlp" and "hipdlp"? The option for "pdlp" should also coincide with what is used in the Summary of solvers.md.

Yes, the "hipdlp" value for solver is still in Yanyu's branch, so that she can run cuPDLPc (by setting "pdlp") for sanity checking, but it will disappear when we have only her PDLP solver

It seems like you removed the statements "Setting the solver option to ... forces the ... solver to be used" from the LP section, since they are now present in the summary. But they still appear in the QP section. For consistency, it may be better to remove them from there as well.

Indeed, I've updated solvers.md

@jajhall
Copy link
Member Author

jajhall commented Jan 30, 2026

Documentation is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants