-
Notifications
You must be signed in to change notification settings - Fork 279
Update solver documentation #2787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latest
Are you sure you want to change the base?
Conversation
|
Closes #2781 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #2787 +/- ##
=======================================
Coverage 80.31% 80.32%
=======================================
Files 348 348
Lines 86093 86095 +2
=======================================
+ Hits 69148 69156 +8
+ Misses 16945 16939 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Closes #2752 |
filikat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In definitions.md for option solver, should there be both "pdlp" and "hipdlp"? The option for "pdlp" should also coincide with what is used in the Summary of solvers.md.
It seems like you removed the statements "Setting the solver option to ... forces the ... solver to be used" from the LP section, since they are now present in the summary. But they still appear in the QP section. For consistency, it may be better to remove them from there as well.
Yes, the "hipdlp" value for solver is still in Yanyu's branch, so that she can run cuPDLPc (by setting "pdlp") for sanity checking, but it will disappear when we have only her PDLP solver
Indeed, I've updated solvers.md |
|
Documentation is fixed |
This page will be correct when cuPDLP-C is replaced by HiPDLP, and the QP IPM solver is added, so this is just a draft PR