Skip to content

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Jan 7, 2026

Description

This PR fixes the behavior of --search_data=quick and --search_data=complete so it resembles the description in the docs.

I also fixed tiny typos and a mypy warning that showed when running pre-commit run --all.

Closes #2936


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added this to the v2.14.0 milestone Jan 7, 2026
@schlunma schlunma requested a review from bouweandela January 7, 2026 13:52
@schlunma schlunma added bug Something isn't working config labels Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.59%. Comparing base (d0eb4c3) to head (fc43775).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2937   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files         266      266           
  Lines       15573    15573           
=======================================
  Hits        14887    14887           
  Misses        686      686           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela merged commit 9244717 into main Jan 15, 2026
4 checks passed
@bouweandela bouweandela deleted the fix_search_data branch January 15, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--search_data=quick does not work as intended

3 participants