-
Notifications
You must be signed in to change notification settings - Fork 145
CMORizer ESACCI-PERMAFROST #3545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
LisaBock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @axel-lauer !
I started the review and run in two issues:
- there were small modifications in the downloader necessary (see comment there)
- when starting the formatter I got the following error message:
PermissionError: [Errno 13] Permission denied: '/work/bd0854/b380103/esacci-permafrost-weights'
Please update also the branch with the main branch.
| Overwrite already downloaded files | ||
| """ | ||
| if start_date is None: | ||
| start_date = datetime(1997, 1, 1, tzinfo=datetime.timezone.utc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives me the following error message:
AttributeError: type object 'datetime.datetime' has no attribute 'timezone'. Did you mean: 'astimezone'?
It worked when I added from datetime import timezone and replaced datetime.timezone with timezone .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just removed the time zone stuff. It seems this is not needed (any more): e74218d
I also updated with the latest main resolving the conflict in input.rst.
| mip: Lyr | ||
| raw: ALT | ||
| file: 'ESACCI-PERMAFROST-L4-ALT-*-AREA4_PP-{year}-fv03.0.nc' | ||
| weights_dir: '/work/bd0854/b380103/esacci-permafrost-weights' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @axel-lauer ,
if these weights are needed, could you store them in a public/group folder or in the ESMValTool repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The weights file should be generated automatically and is then reused to speed up the regridding. Could you try setting
weights_dir: './esacci-permafrost-weights' in the config file? Not sure which directory to give so it works for every user on every machine.
Description
This PR adds a downloading and formatting script for the dataset ESACCI-PERMAFROST v3.0. The following three variables are supported:
The CMORizer requires the custom CMOR tables defined in ESMValGroup/ESMValCore#2358.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated data reformatting script