Expose api_keys on BaseUser model #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReferralCustomer extends BaseUser, which now has the apiKeys field. Having apiKeys in both classes causes a Gson duplicate field error during JSON deserialization.
Justintime50
requested changes
Dec 1, 2025
Member
Justintime50
left a comment
Justintime50
left a comment
There was a problem hiding this comment.
We'll want some changes here
Removed unused import and SerializedName annotation.
Justintime50
approved these changes
Dec 1, 2025
Member
There was a problem hiding this comment.
This should do the trick, though we can't test it via our test suite because we redact the api_keys key in cassettes. I'll release this then give it a whirl before letting the customer know.
We don't typically use the serialized name annotation so I removed it. We use a package lombok which automatically adds getters and automagically knows the names of the keys based on casing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a User via
POST /v2/users, the EasyPost API returns anapi_keysarray on the User object.The Java client currently drops this field during deserialization, which forces consumers to call
GET /v2/api_keysand filter the results in memory. This can be inefficient at scale.This PR:
@SerializedName("api_keys") private List<ApiKey> apiKeys;toBaseUserThis is a backwards-compatible change that simply exposes existing response data and aligns the Java client behavior with other EasyPost client libraries.