breaking changes #358
Merged
breaking changes #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexmatthews
approved these changes
Mar 7, 2025
ralexmatthews
left a comment
ralexmatthews
left a comment
There was a problem hiding this comment.
Nice, LGTM. Mostly just using built-in dict and list vs the typing library ones, and rerecording cassettes 👍
|
|
||
| return convert_to_easypost_object(response=response) | ||
|
|
||
| def all_api_keys(self) -> Dict[str, Any]: |
Comment on lines
+12
to
+22
| "bandit==1.8.*", | ||
| "black==25.*", | ||
| "build==1.2.*", | ||
| "flake8==6.*", | ||
| "isort==6.*", | ||
| "mypy==1.15.*", | ||
| "pdoc==15.*", | ||
| "pytest-cov==6.*", | ||
| "pytest-vcr==1.*", | ||
| "pytest==7.*", | ||
| "vcrpy==4.*", # TODO: vcrpy v5 requires Python 3.8+ | ||
| "pytest==8.*", | ||
| "vcrpy==7.*", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
user.all_api_keysanduser.api_keys, useapi_key.allandapi_key.retrieve_api_keys_for_userrespectivelyListandDicttyping imports as they are builtin types (lowercased) starting in Python 3.9Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.