Skip to content

fix: webhook update params #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Justintime50 merged 9 commits into from
Feb 21, 2025
Merged

fix: webhook update params #319

Justintime50 merged 9 commits into from
Feb 21, 2025

Conversation

@Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Feb 14, 2025 •
edited
Loading

Description

  • Adds Ruby 3.4 support
  • Corrects the HTTP verb for updating a brand from GET to PATCH

Testing

  • Adds param tests for webhooks

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 marked this pull request as ready for review February 19, 2025 18:55
@Justintime50 Justintime50 requested a review from a team as a code owner February 19, 2025 18:55
keheitz
keheitz approved these changes Feb 20, 2025
View reviewed changes
Copy link

@keheitz keheitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Justintime50 Justintime50 merged commit 8c1e964 into master Feb 21, 2025
9 checks passed
@Justintime50 Justintime50 deleted the webhook_params branch February 21, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keheitz keheitz keheitz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Justintime50 @keheitz