fix(ci): pin sh-checker action and restrict workflow permissions #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pin luizm/action-sh-checker from @master to @v0.9.0 to prevent automatic execution of potentially malicious upstream commits. Using a mutable branch reference like @master creates a supply chain attack vector where any new code pushed upstream would run in our CI without review. Additionally, add contents: read permission to the shell job following the principle of least privilege. This restricts the workflow to only the permissions it needs to checkout and lint shell scripts. Changes: - Pin luizm/action-sh-checker to v0.9.0 (vetted release) - Add explicit permissions: contents: read to shell job - Preserve all existing functionality (shfmt, shellcheck options)
Justintime50
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin luizm/action-sh-checker from @master to @v0.9.0 to prevent
automatic execution of potentially malicious upstream commits. Using
a mutable branch reference like @master creates a supply chain attack
vector where any new code pushed upstream would run in our CI without
review.
Additionally, add contents: read permission to the shell job following
the principle of least privilege. This restricts the workflow to only
the permissions it needs to checkout and lint shell scripts.
Changes: