Skip to content

Conversation

@Inglan
Copy link
Member

@Inglan Inglan commented Sep 23, 2025

Summary by CodeRabbit

  • Refactor
    • Removed authentication and account features (login UI, account page).
    • Disabled cloud sync and backups; only local backups remain. Cloud settings save removed.
    • Simplified app providers and identification behavior.
  • Documentation
    • Updated Privacy Policy to remove account/Clerk and database data sections.
  • Chores
    • Cleaned environment variables and removed unused auth-related dependencies.
    • Updated CI workflows: added push triggers and build artifact uploads.

@Inglan Inglan enabled auto-merge September 23, 2025 23:52
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 23, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR removes Clerk authentication and related sync/backup integrations across the app. It deletes Clerk env/config, dependencies, UI components, Convex users schema and auth-backed endpoints, and disables sync/backup utilities. Build workflows are adjusted (remove Clerk env, add artifact upload, add push trigger). Privacy page is updated to remove account-related sections.

Changes

Cohort / File(s) Change summary
Environment samples & config
/.env.example, /vite.config.ts
Remove PUBLIC_CLERK_PUBLISHABLE_KEY from sample env and Vite define mapping; keep other defines unchanged.
GitHub workflows
.github/workflows/build.yml, .github/workflows/deploy.yml, .github/workflows/beta_deploy.yml
Remove PUBLIC_CLERK_PUBLISHABLE_KEY from Build steps; add push trigger and artifact upload step to build.yml; otherwise flows unchanged.
Editor/docs
.github/copilot-instructions.md
Remove Clerk env line from snippet and Clerk mention from Security Considerations.
Dependencies
/package.json
Remove @clerk/backend, @clerk/themes, and svelte-clerk from dependencies.
Convex backend: users/backup/sync
/src/convex/schema.ts, /src/convex/backups.ts, /src/convex/sync.ts, /src/convex/utils.ts
Delete users table; change comments.user and backup.user from v.id('users') to v.string(); comment out backups get/create/remove, sync get/update, and JWT/user utils (no active exports).
Sidebar and providers
/src/lib/components/app-sidebar.svelte, /src/lib/components/providers.svelte, /src/lib/components/sidebar-auth.svelte
Remove Clerk context/components; delete sidebar-auth.svelte; providers no longer wrap with ClerkProvider/GoogleOneTap/themes.
Settings and sync util
/src/lib/components/settings.svelte, /src/lib/sync.ts
Remove token fetching and Clerk/Convex save path; comment out save implementation; UI now avoids token-based persistence.
Routes: account/identify/backups/privacy/layout
/src/routes/account/[...slug]/+page.svelte, /src/routes/identify.svelte, /src/routes/backups/+page.svelte, /src/routes/privacy/+page.svelte, /src/routes/+layout.svelte
Delete account page (Clerk profile). Identify: replace Clerk-driven identify with onMount PostHog reset check. Backups page: remove auth/Convex integration; keep local backups UI; SignedIn/Out UI removed. Privacy: remove Clerk/Convex account data sections and references. Layout: reorder Identify import only.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant App as App (Identify page)
  participant PH as PostHog

  Note over App: New flow (no Clerk)
  User->>App: Load /identify
  App->>App: onMount() with 2s delay
  App->>PH: ph.get_distinct_id()
  alt distinct_id starts with "user_"
    App->>PH: ph.reset()
  else
    Note over App,PH: No action
  end
Loading
sequenceDiagram
  autonumber
  actor User
  participant Page as Backups Page
  participant Local as Local Storage

  Note over Page: Current backups (no auth/Convex)
  User->>Page: Open /backups
  Page->>Local: List existing local backups
  User->>Page: Create/Restore backup
  Page->>Local: Read/Write backup data
  Note over Page: Cloud backup UI disabled
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested reviewers

  • nathblade16
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch main

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e661d83 and 4bb02e1.

⛔ Files ignored due to path filters (3)
  • package-lock.json is excluded by !**/package-lock.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • src/convex/_generated/api.d.ts is excluded by !**/_generated/**
📒 Files selected for processing (21)
  • .env.example (0 hunks)
  • .github/copilot-instructions.md (0 hunks)
  • .github/workflows/beta_deploy.yml (0 hunks)
  • .github/workflows/build.yml (2 hunks)
  • .github/workflows/deploy.yml (0 hunks)
  • package.json (0 hunks)
  • src/convex/backups.ts (1 hunks)
  • src/convex/schema.ts (1 hunks)
  • src/convex/sync.ts (1 hunks)
  • src/convex/utils.ts (1 hunks)
  • src/lib/components/app-sidebar.svelte (0 hunks)
  • src/lib/components/providers.svelte (1 hunks)
  • src/lib/components/settings.svelte (1 hunks)
  • src/lib/components/sidebar-auth.svelte (0 hunks)
  • src/lib/sync.ts (1 hunks)
  • src/routes/+layout.svelte (1 hunks)
  • src/routes/account/[...slug]/+page.svelte (0 hunks)
  • src/routes/backups/+page.svelte (4 hunks)
  • src/routes/identify.svelte (1 hunks)
  • src/routes/privacy/+page.svelte (0 hunks)
  • vite.config.ts (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying edutools-testing with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4bb02e1
Status: ✅  Deploy successful!
Preview URL: https://c56c2227.edutools-testing.pages.dev
Branch Preview URL: https://main.edutools-testing.pages.dev

View logs

@Inglan Inglan merged commit 16351e0 into prod Sep 23, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants