Skip to content

Conversation

@Inglan
Copy link
Member

@Inglan Inglan commented Oct 1, 2025

Summary by CodeRabbit

  • New Features
    • Clickable rows in G and History tables navigate to item details.
  • Refactor
    • About, G, and Backups pages are now gated behind Experimental Features; otherwise show a 404 with a Go home button.
    • Removed per-cell link renderers; navigation handled via row clicks.
  • Style
    • Sidebar transitions updated to ease-out for smoother animations.
  • Chores
    • Removed Convex integration, including configuration, server handlers, schema, utilities, and related dependencies; disabled associated imports and initialization.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR removes Convex backend integration and related client code, deletes server handlers, schema, types, and utilities, cleans up dependencies, and introduces feature-flag gating for several routes. It also replaces link-based table cells with row-level navigation and tweaks a sidebar transition timing.

Changes

Cohort / File(s) Summary of Changes
Convex backend removal
convex.json, src/convex/backups.ts, src/convex/schema.ts, src/convex/sync.ts, src/convex/types.ts, src/convex/utils.ts
Deleted Convex config, schema, server handlers (backups, sync), JWT/user utilities, and JWT payload type.
Dependency cleanup
package.json
Removed dependencies: convex, convex-svelte.
Client Convex integration disabled
src/lib/components/providers.svelte, src/lib/sync.ts, src/routes/backups/backup.svelte
Commented out Convex client imports/setup and related props/usages.
Feature-flag gating added
src/routes/about/+page.svelte, src/routes/backups/+page.svelte, src/routes/g/+page.svelte, src/routes/g/[id]/+page.svelte
Wrapped content with $preferencesStore.experimentalFeatures; added 404 fallback and Button imports.
Table navigation and link removal (g)
src/routes/g/columns.ts, src/routes/g/data-table.svelte, src/routes/g/link.svelte
Removed Link cell/component; rows navigate via goto('/g/{id}'); added cursor-pointer styling.
Table navigation and link removal (history)
src/routes/history/columns.ts, src/routes/history/data-table.svelte, src/routes/history/link.svelte
Removed Link cell/component; rows navigate via goto('/g/{id}'); added cursor-pointer styling.
UI timing tweak
src/lib/components/ui/sidebar/sidebar.svelte
Transition timing changed from ease-linear to ease-out.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Table as DataTable (g/history)
  participant Nav as goto()
  participant Router as Router
  participant Page as /g/{id}

  User->>Table: Click row
  activate Table
  Table->>Nav: goto(`/g/${row.id}`)
  deactivate Table
  activate Nav
  Nav->>Router: Request navigation
  deactivate Nav
  activate Router
  Router->>Page: Load route
  deactivate Router
  activate Page
  Note right of Page: Render Play/Data view
  deactivate Page
Loading
sequenceDiagram
  autonumber
  participant UI as Page Component
  participant Store as preferencesStore
  participant ViewA as Feature View
  participant ViewB as 404 Fallback

  UI->>Store: Read experimentalFeatures
  alt experimentalFeatures = true
    UI->>ViewA: Render
  else experimentalFeatures = false
    UI->>ViewB: Render
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • nathblade16
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch main

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 472ca8e and ccec101.

⛔ Files ignored due to path filters (6)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • src/convex/_generated/api.d.ts is excluded by !**/_generated/**
  • src/convex/_generated/api.js is excluded by !**/_generated/**
  • src/convex/_generated/dataModel.d.ts is excluded by !**/_generated/**
  • src/convex/_generated/server.d.ts is excluded by !**/_generated/**
  • src/convex/_generated/server.js is excluded by !**/_generated/**
📒 Files selected for processing (21)
  • convex.json (0 hunks)
  • package.json (0 hunks)
  • src/convex/backups.ts (0 hunks)
  • src/convex/schema.ts (0 hunks)
  • src/convex/sync.ts (0 hunks)
  • src/convex/types.ts (0 hunks)
  • src/convex/utils.ts (0 hunks)
  • src/lib/components/providers.svelte (1 hunks)
  • src/lib/components/ui/sidebar/sidebar.svelte (2 hunks)
  • src/lib/sync.ts (1 hunks)
  • src/routes/about/+page.svelte (1 hunks)
  • src/routes/backups/+page.svelte (4 hunks)
  • src/routes/backups/backup.svelte (2 hunks)
  • src/routes/g/+page.svelte (1 hunks)
  • src/routes/g/[id]/+page.svelte (1 hunks)
  • src/routes/g/columns.ts (0 hunks)
  • src/routes/g/data-table.svelte (2 hunks)
  • src/routes/g/link.svelte (0 hunks)
  • src/routes/history/columns.ts (0 hunks)
  • src/routes/history/data-table.svelte (2 hunks)
  • src/routes/history/link.svelte (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
edutools Ready Ready Preview Comment Oct 1, 2025 8:45am

@Inglan Inglan enabled auto-merge October 1, 2025 08:44
@cloudflare-workers-and-pages
Copy link

Deploying edutools-testing with  Cloudflare Pages  Cloudflare Pages

Latest commit: ccec101
Status: ✅  Deploy successful!
Preview URL: https://26d013fe.edutools-testing.pages.dev
Branch Preview URL: https://main.edutools-testing.pages.dev

View logs

@Inglan Inglan merged commit e00113f into prod Oct 1, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants