REWRITE EVERYTHING!! #573
Merged
REWRITE EVERYTHING!! #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into react-rewrite
Rebuild from scratch
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis PR performs a comprehensive project restructuring: migrates from pnpm to Bun as package manager, transitions from Svelte to React Router framework, adds Convex backend with Better Auth authentication, introduces 20+ utility tool routes, establishes a complete ShadCN/UI component library, and updates all CI/CD workflows accordingly. Includes new environment variable schema for Vite/PostHog and setup scripts for worktree configuration. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Areas requiring extra attention:
Possibly related PRs
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (22)
📒 Files selected for processing (107)
⛔ Files not processed due to max files limit (30)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 20
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| lastIndex = regex.lastIndex; | ||
|
|
||
| if (!flags.global) break; | ||
| } |
There was a problem hiding this comment.
Bug: Regex tester can freeze browser with zero-length matches
The highlightMatches function can cause an infinite loop and freeze the browser. This happens when a global regex matches a zero-length string, as regex.exec() doesn't advance regex.lastIndex in such cases.
| onClick={() => { | ||
| setIndentation(2); | ||
| if (output && !error) formatJson(); | ||
| }} |
There was a problem hiding this comment.
Bug: JSON formatter uses stale indentation value after state change
When clicking the indentation buttons (2 Spaces / 4 Spaces), setIndentation() is called immediately followed by formatJson(). However, React state updates are asynchronous, so formatJson() captures the old indentation value from the closure rather than the newly set value. The output won't reflect the selected indentation until a second format action is triggered.
Additional Locations (1)
| COPY --from=production-dependencies-env /app/node_modules /app/node_modules | ||
| COPY --from=build-env /app/build /app/build | ||
| WORKDIR /app | ||
| CMD ["npm", "run", "start"] No newline at end of file |
There was a problem hiding this comment.
Bug: Dockerfile uses npm but project migrated to bun
The Dockerfile uses npm ci with package-lock.json, but the project has migrated to bun (as seen in README, GitHub workflows, and setup scripts). The package-lock.json file won't exist when using bun (which generates bun.lockb), causing the Docker build to fail when copying or installing dependencies.
| .catch((error) => { | ||
| if (error == "AbortError: Share canceled") return; | ||
| toast.error("Failed to share"); | ||
| }); |
There was a problem hiding this comment.
Bug: Share cancellation incorrectly triggers error toast
The error handling in the share function compares an Error object to a string using error == "AbortError: Share canceled". When users cancel the Web Share dialog, the browser throws a DOMException object with name === "AbortError", not a string. This comparison will always be false, causing "Failed to share" toast to appear whenever users intentionally cancel sharing. The check needs to compare error.name === "AbortError" instead.
| if (ctx) { | ||
| ctx.fillStyle = bgColor; | ||
| ctx.fillRect(0, 0, size, size); | ||
| ctx.drawImage(img, 0, 0); |
There was a problem hiding this comment.
Bug: QR code download renders wrong size when exceeding preview cap
The QR code preview is capped at 280px (size > 280 ? 280 : size) but the download function creates a canvas at the user-selected size. Since ctx.drawImage(img, 0, 0) is called without explicit dimensions, the 280px SVG is drawn at its native size on a potentially 512px canvas. When a user selects 512px, they get a 512x512 PNG with the QR code only occupying a 280x280 area in the top-left corner. The comment claims "real size for download" but the SVG dimensions are what get drawn.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Remove bundled game assets and static tool content (Cookie Clicker, BitLife, etc.) from the repo.
static/_app/tools/cookieclicker/assets (scripts, images, locales, HTML, mods), including major JS files (eg.DungeonGen.js,ajax.js,dungeons.js), sound/image lists, and localization files (loc/CS.js,loc/DE.js).static/_app/tools/bitlife/(index.html,TemplateData/UnityProgress.js).static/_app/tools/directory.Written by Cursor Bugbot for commit f92ae54. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
New Features
Infrastructure
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.