Open
Conversation
Thanks to @erickcestari for reporting and suggesting a fix.
asan doesn't like math on NULL pointers, even when the result is unused. This causes fuzzing to report false memory leaks when asan trips, so trivially avoid it.
Don't take a dst parameter where not needed.
Enable continuous security testing through libFuzzer integration. Fuzzing helps discover memory corruption bugs, parsing edge cases, and undefined behavior that traditional unit tests often miss. Add --enable-fuzzing, --enable-address-sanitizer, and --enable-ub-sanitizer options to both autotools and CMake. Initial fuzz target covers PSBT parsing with round-trip verification to catch serialization inconsistencies.
Avoids false positives on e.g. x86 platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @erickcestari for the implementation!