Various improvements for 5.1 #368
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Save 5.1 settings as Settings_v5_1.json instead of Settings.json. - Save the original custom preset JSONs strings instead of always converting them to objects. This helps maintaining presets when loading up a different version of the rando where some options have been changed. (The custom presets were being deserialized and then serialized even if you never touched them, potentially removing unrecognized options.) - Make the JSON serialization even safer
This should fix an inconsistency when cancelling out of a level up, and the next level up value shown.
- Streamline enum IsRandom() functionality more - Switch to setting the randomized ranges for some enums via attributes
- Fix issues with FillPalaceRooms/ApplyAsmPatches using/writing Hyrule.r and Hyrule.ROMData fields instead of the objects passed as arguments. - Actually hash the ROM instead of only hashing shallow values. This still has to be done before any customization is applied, so it wont be the final ROM. There is plenty of room to improve the separation regarding that. - Separate some Hyrule assembly functions so they make more sense.
initsu
force-pushed
the
stat-refactoring-improvements
branch
from
88e70ac to
d32e653
Compare
On the UI side, it uses more reactive programming now. A lot of unnecessary extra flags (de)serializations were removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some things that are ready for review. More things are in progress.
See commit messages for details!