Skip to content

Conversation

@me4502
Copy link
Member

@me4502 me4502 commented Dec 12, 2020

Add support for parsing NBT data in the item parser.

This is a precursor for "Tools v2".

Ideally we can also remove the existing NBT classes once we switch to adventure-nbt.

EngineHub/worldedit-adapters#23

@me4502 me4502 requested a review from a team December 12, 2020 11:06
@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #1611 (b7880c2) into master (476342a) will decrease coverage by 0.34%.
The diff coverage is 1.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1611      +/-   ##
============================================
- Coverage     11.80%   11.45%   -0.35%     
+ Complexity     1055     1002      -53     
============================================
  Files           801      804       +3     
  Lines         32703    32577     -126     
  Branches       3801     3738      -63     
============================================
- Hits           3860     3732     -128     
- Misses        28654    28667      +13     
+ Partials        189      178      -11     
Impacted Files Coverage Δ Complexity Δ
.../java/com/sk89q/worldedit/bukkit/BukkitPlayer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/java/com/sk89q/worldedit/bukkit/BukkitWorld.java 12.13% <0.00%> (ø) 5.00 <0.00> (ø)
...9q/worldedit/bukkit/adapter/BukkitImplAdapter.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...va/com/sk89q/worldedit/blocks/MobSpawnerBlock.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...acy/java/com/sk89q/worldedit/blocks/SignBlock.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...cy/java/com/sk89q/worldedit/blocks/SkullBlock.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ain/java/com/sk89q/jnbt/AdventureNBTConverter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ore/src/main/java/com/sk89q/jnbt/ByteArrayTag.java 0.00% <0.00%> (-90.91%) 0.00 <0.00> (-4.00)
...dit-core/src/main/java/com/sk89q/jnbt/ByteTag.java 0.00% <0.00%> (-80.00%) 0.00 <0.00> (-2.00)
...c/main/java/com/sk89q/jnbt/CompoundTagBuilder.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476342a...b7880c2. Read the comment docs.

@me4502 me4502 force-pushed the feature/nbt-parsing branch from e9c90d7 to d82c612 Compare December 23, 2020 10:50
@me4502 me4502 force-pushed the feature/nbt-parsing branch from 0b9c8d5 to 252e605 Compare January 16, 2021 04:30
@octylFractal octylFractal added the status:accepted Will be fixed / added to WorldEdit, eventually label Jan 18, 2021
@octylFractal octylFractal added this to the 7.3.0 milestone Jan 18, 2021
@octylFractal octylFractal added the type:feature-request Request for something new label Jan 18, 2021
@me4502 me4502 force-pushed the feature/nbt-parsing branch 3 times, most recently from 1b58d7b to 3365963 Compare February 3, 2021 11:41
@me4502 me4502 force-pushed the feature/nbt-parsing branch from 43688da to ed41a87 Compare February 5, 2021 12:40
@me4502 me4502 force-pushed the feature/nbt-parsing branch from 5f7c2a9 to 137c266 Compare February 6, 2021 10:23
@me4502 me4502 force-pushed the feature/nbt-parsing branch from d03fb8d to 4ac2bb3 Compare February 8, 2021 12:08
@me4502 me4502 merged commit 2c7ac3d into master Feb 15, 2021
@me4502 me4502 deleted the feature/nbt-parsing branch February 15, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:accepted Will be fixed / added to WorldEdit, eventually type:feature-request Request for something new

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants