Fix inserted response time #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In mcast_mquery4, use IGMP_RESPONSE_INTERVAL instead of the Query Interval when building packets. The IGMP header field "Max Response Time" must reflect the time hosts have to reply (10s), not the time between proxy queries (125s). Scale the value by IGMP_TIMER_SCALE (10) to match the IGMP wire format of deciseconds.
bket
force-pushed
the
fix-inserted-response-time
branch
from
89446f6 to
0eefefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 2236 states "The Max Response Time inserted into the periodic General Queries. Default: 100 (10 seconds)".
Checked against internals of igmpproxy.
While here improve readability a bit.