-
-
Notifications
You must be signed in to change notification settings - Fork 9
GH-148 Implement mentions system with @player detection and sound notifications #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
16
commits into
master
Choose a base branch
from
copilot/add-mentions-sound-feature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d17b275
Bump dependencies and Gradle
Jakubk15 2dbe929
Initial plan
Copilot a510853
Initial commit - planning mentions system implementation
Copilot 839a39f
Implement mentions system with @player detection and sound notifications
Copilot 40b63ba
Add tests and documentation for mentions feature
Copilot 917834f
Address code review feedback - improve error handling and switch syntax
Copilot f030cd6
Merge branch 'master' into update-gradle-and-deps
Jakubk15 1212723
fix: configuration cache errors related to runServer
Jakubk15 58ce9e9
Merge branch 'update-plugin-yml' into copilot/add-mentions-sound-feature
Jakubk15 04cff90
feat: add mention sounds feature and improve configuration
Jakubk15 b07f8f4
Refactor placeholders format in README.md
Jakubk15 37a4da0
Update placeholders section in README.md
Jakubk15 64cb446
Update chatformatter-core/src/main/java/com/eternalcode/formatter/men…
Jakubk15 fe13db6
Revert reload command refactor
Jakubk15 59b2265
Revert code arrangement
Jakubk15 5ac4ff7
CR
Rollczi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package com.eternalcode.formatter.mention; | ||
|
|
||
| import net.dzikoysk.cdn.entity.Contextual; | ||
| import net.dzikoysk.cdn.entity.Description; | ||
|
|
||
| import java.io.Serializable; | ||
|
|
||
| @Contextual | ||
| public class MentionConfig implements Serializable { | ||
|
|
||
| @Description({ " ", "# Mention system configuration" }) | ||
| @Description("# When a player mentions another player with @playername, the mentioned player will hear a sound") | ||
| public boolean enabled = true; | ||
|
|
||
| @Description({ " ", "# The sound to play when a player is mentioned" }) | ||
| @Description("# Available sounds: https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/Sound.html") | ||
| public String sound = "BLOCK_NOTE_BLOCK_PLING"; | ||
|
|
||
| @Description({ " ", "# The volume of the mention sound (0.0 to 1.0)" }) | ||
| public float volume = 1.0f; | ||
|
|
||
| @Description({ " ", "# The pitch of the mention sound (0.5 to 2.0)" }) | ||
| public float pitch = 1.0f; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont use static imports