GH-1212 Replace JetBrains nullability annotations with JSpecify by Jakubk15 · Pull Request #1288 · EternalCodeTeam/EternalCore

Jakubk15 · 2026-01-31T14:35:53Z

This PR replaces nullability annotations from JetBrains with the ones from JSpecify.

Resolves #1212

… nullability

gemini-code-assist

Code Review

This pull request successfully replaces JetBrains nullability annotations with JSpecify annotations across the project. The changes are thorough and consistent. I've added one suggestion to improve annotation correctness in one of the files, making the nullability contract more precise. Overall, this is a great refactoring that improves code standardization.

...e-core/src/main/java/com/eternalcode/core/bridge/placeholderapi/PlaceholderApiExtension.java

…ceholderapi/PlaceholderApiExtension.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

noyzys

Trzeba też pamiętać jedno mieszanie adnotacji JetBrains i JSpecify mogłoby utrudnić interpretację kontraktów nullability, dlatego intencją jest pełne przejście na JSpecify w całym projekcie co za tym idzie zmiany w codebse.

Migracja do JSpecify jest celowa - chodzi o spójny, specyfikacyjny model nullability pseudo nullsafety i unikanie mieszania różnych frameworków adnotacji.
Twoja sugestia faktycznie poprawia precyzję kontraktu, więc ja daję approve aczkolwiek nie spamował bym tym na dużą skale.

noyzys · 2026-02-02T08:47:38Z

@noyzys Problem w tym, że JSpecify posiada tylko adnotację dotyczące nullability, a nie posiada takich rzeczy jak chociażby @ApiStatus, czy @Unmodifiable

Dlatego trzeba iść drogą hybrydową

...e-core/src/main/java/com/eternalcode/core/bridge/placeholderapi/PlaceholderApiExtension.java

eternalcore-core/src/main/java/com/eternalcode/core/delay/InstantExpiry.java

...re-core/src/main/java/com/eternalcode/core/feature/adminchat/AdminChatChannelController.java

eternalcore-core/src/main/java/com/eternalcode/core/feature/adminchat/AdminChatCommand.java

imDMK · 2026-02-02T13:02:28Z

...ore/src/main/java/com/eternalcode/core/feature/customcommand/CustomCommandBukkitWrapper.java

            NoticeService noticeService,
            Notice message,
            List<String> commands


Suggested change

NoticeService noticeService,

Notice message,

List<String> commands

@NonNull NoticeService noticeService,

@NonNull Notice message,

@NonNull List<String> commands

Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>

CitralFlo

I checked services and annotated more - Nullable elements are not marked in your code.

Additionally inside code i added jetbrains annotation for better intelliJ usage - current screems when @NullMarked is used.

All Api methods should use jspecific

Review in pull request form: #1293

* My understanding of JSpecify for api - mostly used in Java-Kotlin communication. With NullMarked as clear way to display notnull by default. Nullmarks checked to second layer of services. Additional `NotNull` s from jetbrains required by intelliJ to not screen about parameter marks as notNull * Additional marks * Use global @NullMarked defined at package-info.java * Update eternalcore-api/src/main/java/com/eternalcode/core/feature/catboy/CatboyService.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update eternalcore-api/src/main/java/com/eternalcode/core/feature/adminchat/event/AdminChatEvent.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update eternalcore-api/src/main/java/com/eternalcode/core/feature/jail/JailService.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update eternalcore-core/src/main/java/com/eternalcode/core/feature/warp/WarpServiceImpl.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Remove unnecessary annotations * Update eternalcore-api/src/main/java/com/eternalcode/core/feature/spawn/SpawnService.java * Update eternalcore-core/src/main/java/com/eternalcode/core/feature/spawn/SpawnServiceImpl.java * Update eternalcore-api/src/main/java/com/eternalcode/core/EternalCoreApiProvider.java * Update eternalcore-api/src/main/java/com/eternalcode/core/EternalCoreApiProvider.java * Update eternalcore-api/src/main/java/com/eternalcode/core/EternalCoreApiProvider.java * Update eternalcore-api/src/main/java/com/eternalcode/core/feature/warp/event/PreWarpTeleportEvent.java * Minor touchups * Add @ApiStatus.Internal annotation to deinitialize() method --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Jakub Kędziora <77227023+Jakubk15@users.noreply.github.com>

refactor: Replace JetBrains annotations with JSpecify annotations for…

db9c2d2

… nullability

Jakubk15 requested a review from a team as a code owner January 31, 2026 14:35

Jakubk15 requested review from CitralFlo, Pawelusze, igoyek, imDMK, noyzys and vLuckyyy January 31, 2026 14:35

Jakubk15 changed the title ~~Replace JetBrains annotations with JSpecify annotations for nullability~~ GH-1212 Replace JetBrains annotations with JSpecify annotations for nullability Jan 31, 2026

gemini-code-assist bot reviewed Jan 31, 2026

View reviewed changes

...e-core/src/main/java/com/eternalcode/core/bridge/placeholderapi/PlaceholderApiExtension.java Outdated Show resolved Hide resolved

Update eternalcore-core/src/main/java/com/eternalcode/core/bridge/pla…

74a808a

…ceholderapi/PlaceholderApiExtension.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

noyzys approved these changes Feb 2, 2026

View reviewed changes

imDMK approved these changes Feb 2, 2026

View reviewed changes

Jakubk15 and others added 6 commits February 2, 2026 14:26

Update AdminChatCommand.java

a65339d

Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>

Update AdminChatCommand.java

b9bd8db

Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>

Update AdminChatChannelController.java

0d6e005

Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>

Update AdminChatChannelController.java

58b4286

Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>

Update AdminChatChannelController.java

3fc32c7

Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>

Update InstantExpiry.java

8057ad3

Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>

igoyek approved these changes Feb 4, 2026

View reviewed changes

Jakubk15 changed the title ~~GH-1212 Replace JetBrains annotations with JSpecify annotations for nullability~~ GH-1212 Replace JetBrains nullability annotations with JSpecify Feb 5, 2026

CitralFlo requested changes Feb 7, 2026

View reviewed changes

Jakubk15 requested a review from CitralFlo February 7, 2026 10:31

Merge branch 'master' into migrate-to-jspecify

fa32c24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GH-1212 Replace JetBrains nullability annotations with JSpecify#1288

GH-1212 Replace JetBrains nullability annotations with JSpecify#1288
Jakubk15 wants to merge 10 commits intomasterfrom
migrate-to-jspecify

Jakubk15 commented Jan 31, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

noyzys left a comment

Uh oh!

noyzys commented Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imDMK Feb 2, 2026

Uh oh!

CitralFlo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Jakubk15 commented Jan 31, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

noyzys left a comment

Choose a reason for hiding this comment

Uh oh!

noyzys commented Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imDMK Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

CitralFlo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants