Add smooth cutoffs to distance tolerances #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtaylor
deleted the
34-proposal-add-smooth-cutoffs-to-distance-tolerances
branch
nedtaylor
added a commit
that referenced
this pull request
Jun 13, 2025
…tion ## Added - Added smooth cutoffs to distance tolerances - Added smooth cutoffs to 3- and 4-body contributions to `evaluate_point()` - Viability function is now a more continuous surface (abrupt when transitioning below cutoff_min) - Added descriptor generator procedure - Added unit tests for distribution convergence - Added probability density generation procedure - Added `set_method_ratio_default` procedure ## Changed - Changed Python docstrings style to match [NumPy Style Guide](https://numpydoc.readthedocs.io/en/latest/format.html) - Specified expected types for Python arguments - Converted all custom `modu` calls to `norm2` - Optimised `evaluate` and `viability` modules - Optimised array indexing - Moved `atom_ignore_index` array to boolean inside `basis_type` - Acts as a mask for atoms ## Fixed - Fixed handling of optional method ratio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
evaluate_point()set_method_ratio_defaultprocedureChanged
moducalls tonorm2evaluateandviabilitymodulesatom_ignore_indexarray to boolean insidebasis_typeFixed
Issues
Closes #34