Skip to content

Fix inconsistent Expenses footer behavior when returning from saved search #78398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marufsharifi wants to merge 5 commits into
base: main
Choose a base branch
from
+5 −4
Open

Fix inconsistent Expenses footer behavior when returning from saved search #78398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42b6df1
Fix inconsistent Expenses footer behavior when returning from saved s…
marufsharifi Dec 23, 2025
40e8b23
Merge branch 'main' into fix/reports-expenses-footer-on-saved-search-…
marufsharifi Dec 30, 2025
f0016f7
Merge branch 'main' into fix/reports-expenses-footer-on-saved-search-…
marufsharifi Jan 1, 2026
e82fb82
Merge branch 'main' into fix/reports-expenses-footer-on-saved-search-…
marufsharifi Jan 4, 2026
c329012
wait for saveSearch to be done. then navigate.
marufsharifi Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/libs/SearchQueryUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,10 @@ function getQueryHashes(query: SearchQueryJSON): {primaryHash: number; recentSea
orderedQuery += ` ${CONST.SEARCH.SYNTAX_ROOT_KEYS.STATUS}:${Array.isArray(query.status) ? query.status.join(',') : query.status}`;
orderedQuery += ` ${CONST.SEARCH.SYNTAX_ROOT_KEYS.GROUP_BY}:${query.groupBy}`;

if (query.policyID) {
orderedQuery += ` ${CONST.SEARCH.SYNTAX_FILTER_KEYS.POLICY_ID}:${Array.isArray(query.policyID) ? query.policyID.join(',') : query.policyID} `;
}

const filterSet = new Set<string>(orderedQuery);

// Certain filters shouldn't affect whether two searchers are similar or not, since they dont
Expand Down Expand Up @@ -376,9 +380,6 @@ function getQueryHashes(query: SearchQueryJSON): {primaryHash: number; recentSea
orderedQuery += ` ${CONST.SEARCH.SYNTAX_ROOT_KEYS.SORT_ORDER}:${query.sortOrder}`;
orderedQuery += ` ${CONST.SEARCH.SYNTAX_ROOT_KEYS.COLUMNS}:${Array.isArray(query.columns) ? query.columns.join(',') : query.columns}`;

if (query.policyID) {
orderedQuery += ` ${CONST.SEARCH.SYNTAX_FILTER_KEYS.POLICY_ID}:${Array.isArray(query.policyID) ? query.policyID.join(',') : query.policyID} `;
}
const primaryHash = hashText(orderedQuery, 2 ** 32);

return {primaryHash, recentSearchHash, similarSearchHash};
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Search/AdvancedSearchFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ function AdvancedSearchFilters() {
queryJSON,
});

applyFiltersAndNavigate();
Navigation.setNavigationActionToMicrotaskQueue(() => applyFiltersAndNavigate());
};

const filters = typeFiltersKeys.map((section) => {
Expand Down
Loading