fix: Add bold to excludeRangeTypesFromFormatting to fix emoji duplication on web#747
Merged
jmusial merged 1 commit intoExpensify:mainfrom Jan 7, 2026
Conversation
Collaborator
|
will take a look later today |
8 tasks
jmusial
approved these changes
Jan 7, 2026
Collaborator
jmusial
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the contribution and the tests <3 !
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When combining bold formatting with emojis (e.g.,
*bold 😀 text*), the web platform displays duplicate emoji characters and causes cursor positioning issues.The
excludeRangeTypesFromFormattingfunction splits markdown ranges at emoji boundaries to prevent overlapping ranges. This was being called foritalicandstrikethrough, butboldwas missing. The web DOM builder uses nested elements that cannot handle overlapping ranges correctly, causing text duplication.This PR adds
boldto theexcludeRangeTypesFromFormattingcalls alongsideitalicandstrikethrough.Native platforms are unaffected because they use a flat styling approach that handles overlapping ranges gracefully.
Related Issues
#746
Expensify/App#75294
Manual Tests
Linked PRs