feat: add Google Pay yellow path #40

dbracamonte · 2025-08-29T15:53:02Z

This PR introduces new features to integrate the Google Pay yellow path flow, allowing users to resume adding cards to Google Wallet and managing existing tokens. This is essential to comply with Google Pay requirements.

Summary

Add resumeAddCardToGoogleWallet() method for resuming card provisioning using existing token reference ID
Add listTokens() method to retrieve all tokens stored in Google Wallet
Add new TypeScript types: AndroidResumeCardData and TokenInfo
Update README.md with comprehensive documentation for the new methods

Changes Made

Android Native (Kotlin)

WalletModule.kt: Added resumeAddCardToGoogleWallet and listTokens methods with proper error handling
NativeWalletSpec.java: Added method signatures for the new functionality

TypeScript/React Native

NativeWallet.ts: Added new types and method signatures to the TurboModule spec
index.tsx: Implemented JavaScript wrapper functions with proper platform checks and error handling

Documentation

README.md: Updated API reference table, data types section, and function count

Features

`resumeAddCardToGoogleWallet(cardData: AndroidResumeCardData)`

Resumes card provisioning flow using an existing tokenReferenceId
Simplified data structure compared to full card provisioning
Supports optional cardholder name and last digits for display purposes
Returns TokenizationStatus to track the operation result

`listTokens()`

Retrieves all tokens currently stored in Google Wallet
Returns array of TokenInfo objects containing:
- tokenReferenceId: Unique token identifier
- fpanLastFour: Last four digits of the tokenized card
- tokenState: Current state of the token (numeric value)
Handles empty results gracefully

github-actions · 2025-08-29T15:53:11Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

dbracamonte · 2025-08-29T15:57:19Z

I have read the CLA Document and I hereby sign the CLA

Skalakid

Overall, it looks good. I've left some comments. Additionally, could you please add a video to the PR description that demonstrates how your solution works in our example app?

example/src/walletUtils.ts

src/NativeWallet.ts

src/index.tsx

src/NativeWallet.ts

README.md

android/src/main/java/com/expensify/wallet/WalletModule.kt

dbracamonte · 2025-09-01T19:47:10Z

Overall, it looks good. I've left some comments. Additionally, could you please add a video to the PR description that demonstrates how your solution works in our example app?

Thanks for the review!

Regarding the demo video, I need to clarify the testing constraints:

To demonstrate the Google Pay tokenization flow, I would need:

Production certificates from Google Pay (which I don't currently have access to)
Google-authorized test cards for the sandbox environment

The testing I performed was done using my work environment, but I cannot share that footage publicly as it contains
proprietary information from an unreleased application.

dbracamonte · 2025-09-04T14:03:33Z

Greetings @Skalakid, I'm looking forward to continuing the approval process. If there's any way I can proceed, please let me know.

Skalakid · 2025-09-05T09:36:01Z

Hello, had to finish some other tasks. We need to check if it actually works before merging. Since you've tested it in your unreleased app and can't attach a video here, I think we can try testing it in the Expensify app. I will try to add this flow there and will come back to you with more information

Skalakid

@dbracamonte Finally got some time to test this PR. Everything works fine. Left some last comments, and I think we can merge it ;)

yellow-path.mp4

android/src/main/java/com/expensify/wallet/WalletModule.kt

dbracamonte · 2025-09-19T22:10:58Z

Greetings @Skalakid, I look forward to your comments so we can continue with the integration.

zfurtak

Since @Skalakid is ooo right now, I'll take over this one. Code looks fine, all the comments have been addressed, so I think we can merge it 😊

zfurtak · 2025-09-22T09:15:42Z

Apparently, due to requested changes I can't merge it without Michał's approval, so we have to wait until next Monday

dbracamonte · 2025-10-01T13:55:58Z

Hello @zfurtak thanks for your feedback. I'm waiting on @Skalakid approval to proceed with the merge.

ShpetimA · 2025-10-01T14:22:25Z

@zfurtak @Skalakid Any info on when this pr will be merged or should i fork for the meantime for yellow path ?

Skalakid

Sorry, I've been OOO and couldn't approve this PR. LGTM, thank you!

Skalakid · 2025-10-03T08:52:08Z

Hmm I still can't merge it :/ @dbracamonte can you sign your commit please? This should help

- add resumeAddCardToGoogleWallet() method for resuming card provisioning using existing token reference ID - add listTokens() method to retrieve all tokens stored in Google Wallet - add AndroidResumeCardData and TokenInfo types for new functionality - update README.md with documentation for new methods These methods provide better token lifecycle management and support for existing card tokens in Google Wallet integration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

dbracamonte · 2025-10-03T17:52:13Z

Done @Skalakid, I've already verified the commits.

Skalakid · 2025-10-06T07:17:36Z

@dbracamonte Once again, thank you for the PR!

os-botify · 2025-10-06T07:18:05Z

🚀 Published to npm in 0.1.13 🎉

wcastand · 2025-10-07T10:41:31Z

@dbracamonte @Skalakid
sorry for the question but i thought the yellow path was to verify a card added by the wallet app but from my tests, if i start adding the card from the wallet, i get to the verify identity and i use the resume add card which i expected it to validate the identity and finish adding the card like the normal green flow.

but i still get stuck on verify identity, not sure if it's me doing something wrong or the expected behavior :/

Skalakid · 2025-10-08T06:52:49Z

@wcastand the new resume function won't get you through the identity verification. It's something that should be configured with your card issuer, and you, as a user, should do it. It's a part of native in-app provisioning flow, and the library doesn't do anything with it. You can verify your card by calling the bank, for example

wcastand · 2025-10-08T09:09:02Z

yeah we disabled SMS code because of fraud and calling us doesn't help (we have no way to verify the card) so i need to check with issuer how to config the app verification then thanks 🙏 just wanted to confirm before i keep asking them until they actually help x)

Thanks again for the help and the lib. guessing the same applies to apple pay then, the requireActivation on apple side of things doesn't require a resume?

melvin-bot bot assigned dbracamonte Aug 29, 2025

CLABotify added a commit to Expensify/CLA that referenced this pull request Aug 29, 2025

@dbracamonte has signed the CLA in Expensify/react-native-wallet#40

ba1eb1c

dbracamonte changed the title ~~feat: add Google Wallet token management methods~~ feat: add Google Pay yellow path Aug 29, 2025

dbracamonte mentioned this pull request Aug 29, 2025

Android Google Pay yellow path #33

Closed

Skalakid requested review from Skalakid and zfurtak September 1, 2025 06:25

Skalakid requested changes Sep 1, 2025

View reviewed changes

example/src/walletUtils.ts Outdated Show resolved Hide resolved

src/NativeWallet.ts Outdated Show resolved Hide resolved

src/index.tsx Show resolved Hide resolved

src/NativeWallet.ts Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

Skalakid reviewed Sep 1, 2025

View reviewed changes

android/src/main/java/com/expensify/wallet/WalletModule.kt Outdated Show resolved Hide resolved

Skalakid reviewed Sep 16, 2025

View reviewed changes

android/src/main/java/com/expensify/wallet/WalletModule.kt Show resolved Hide resolved

android/src/main/java/com/expensify/wallet/WalletModule.kt Show resolved Hide resolved

Skalakid reviewed Sep 18, 2025

View reviewed changes

android/src/main/java/com/expensify/wallet/WalletModule.kt Outdated Show resolved Hide resolved

zfurtak previously approved these changes Sep 22, 2025

View reviewed changes

Skalakid previously approved these changes Oct 3, 2025

View reviewed changes

os-botify bot and others added 6 commits October 3, 2025 14:17

Update package.json version to 0.1.7

28a610e

feat(android): add resumeAddCardToGoogleWallet example code

9392cba

feat(types): rename TokenInfo fields for cross-platform compatibility

e29f876

feat: add stub for listTokens on iOS, returning an empty array

e0afe26

feat: add getDisplayName to addCardToGoogleWallet

ec9a64b

dbracamonte force-pushed the feature/google-pay-yellow-path branch from 4a8c972 to ec9a64b Compare October 3, 2025 17:20

Merge branch 'main' into feature/google-pay-yellow-path

af359f4

dbracamonte dismissed stale reviews from Skalakid and zfurtak via af359f4 October 3, 2025 17:51

Skalakid approved these changes Oct 6, 2025

View reviewed changes

Skalakid merged commit dd85fd6 into Expensify:main Oct 6, 2025
3 checks passed

feat: add Google Pay yellow path #40

feat: add Google Pay yellow path #40

Uh oh!

Conversation

dbracamonte commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Android Native (Kotlin)

TypeScript/React Native

Documentation

Features

resumeAddCardToGoogleWallet(cardData: AndroidResumeCardData)

listTokens()

Uh oh!

github-actions bot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbracamonte commented Aug 29, 2025

Uh oh!

Skalakid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbracamonte commented Sep 1, 2025

Uh oh!

dbracamonte commented Sep 4, 2025

Uh oh!

Skalakid commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Skalakid left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbracamonte commented Sep 19, 2025

Uh oh!

zfurtak left a comment

Choose a reason for hiding this comment

Uh oh!

zfurtak commented Sep 22, 2025

Uh oh!

dbracamonte commented Oct 1, 2025

Uh oh!

ShpetimA commented Oct 1, 2025

Uh oh!

Skalakid left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skalakid commented Oct 3, 2025

Uh oh!

dbracamonte commented Oct 3, 2025

Uh oh!

Uh oh!

Skalakid commented Oct 6, 2025

Uh oh!

os-botify bot commented Oct 6, 2025

Uh oh!

wcastand commented Oct 7, 2025

Uh oh!

Skalakid commented Oct 8, 2025

Uh oh!

wcastand commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

dbracamonte commented Aug 29, 2025 •

edited

Loading

`resumeAddCardToGoogleWallet(cardData: AndroidResumeCardData)`

`listTokens()`

github-actions bot commented Aug 29, 2025 •

edited

Loading

Skalakid commented Sep 5, 2025 •

edited

Loading

Skalakid left a comment •

edited

Loading

Skalakid left a comment •

edited

Loading