Skip to content

Unify component names #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skalakid merged 2 commits into from
Sep 10, 2025
Merged

Unify component names #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8016e86
Unify component names
Skalakid Sep 8, 2025
40ecd53
Merge branch 'main' into @Skalakid/unify-component-name
Skalakid Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/src/main/java/com/expensify/wallet/WalletPackage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.expensify.wallet

import com.expensify.wallet.components.AddToWalletButtonViewManager
import com.expensify.wallet.components.RNAddToWalletButtonManager
import com.facebook.react.BaseReactPackage
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.NativeModule
Expand Down Expand Up @@ -44,5 +44,5 @@ class WalletPackage : BaseReactPackage() {
}

override fun createViewManagers(reactContext: com.facebook.react.bridge.ReactApplicationContext)
: List<ViewManager<*, *>> = listOf(AddToWalletButtonViewManager())
: List<ViewManager<*, *>> = listOf(RNAddToWalletButtonManager())
}
8 changes: 4 additions & 4 deletions ...ponents/RNAddToWalletButtonViewManager.kt → .../components/RNAddToWalletButtonManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ import com.facebook.react.uimanager.SimpleViewManager
import com.facebook.react.uimanager.ThemedReactContext
import com.facebook.react.uimanager.annotations.ReactProp

class AddToWalletButtonViewManager : SimpleViewManager<AddToWalletButtonView>() {
class RNAddToWalletButtonManager : SimpleViewManager<RNAddToWalletButtonView>() {

override fun getName(): String = "RNAddToWalletButton"

override fun createViewInstance(reactContext: ThemedReactContext): AddToWalletButtonView {
return AddToWalletButtonView(reactContext)
override fun createViewInstance(reactContext: ThemedReactContext): RNAddToWalletButtonView {
return RNAddToWalletButtonView(reactContext)
}

@ReactProp(name = "buttonType")
fun setButtonType(view: AddToWalletButtonView, type: String) {
fun setButtonType(view: RNAddToWalletButtonView, type: String) {
view.setButtonType(type)
}
}
2 changes: 1 addition & 1 deletion android/src/main/java/com/expensify/wallet/components/RNAddToWalletButtonView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import com.expensify.wallet.R
import android.view.LayoutInflater
import android.view.View

class AddToWalletButtonView(context: Context) : FrameLayout(context) {
class RNAddToWalletButtonView(context: Context) : FrameLayout(context) {

private var buttonView: View? = null
private var buttonType: String = "basic"
Expand Down
4 changes: 2 additions & 2 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1806,7 +1806,7 @@ PODS:
- ReactCommon/turbomodule/core
- SocketRocket
- Yoga
- react-native-wallet (0.1.8):
- react-native-wallet (0.1.9):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -2613,7 +2613,7 @@ SPEC CHECKSUMS:
React-Mapbuffer: e402e7a0535b2213c50727553621480fe8cd8ade
React-microtasksnativemodule: a63ce5595016996a9bac1f10c70a7a7fe6506649
react-native-safe-area-context: c6e2edd1c1da07bdce287fa9d9e60c5f7b514616
react-native-wallet: 48e8d0417dbe38917c585c1d3665cb09cebd6871
react-native-wallet: e929bf18d6f4ac35ee263ff4319e9ef107ae2cd9
React-NativeModulesApple: b3766e1f87b08064ebc459b9e1538da2447ca874
React-oscompat: 34f3d3c06cadcbc470bc4509c717fb9b919eaa8b
React-perflogger: a1edb025fd5d44f61bf09307e248f7608d7b2dcf
Expand Down
2 changes: 1 addition & 1 deletion ios/components/RNAddToWalletButtonManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import React
@objc(RNAddToWalletButtonManager)
class RNAddToWalletButtonManager: RCTViewManager {
override func view() -> UIView! {
return AddToWalletButtonView()
return RNAddToWalletButtonView()
}

override static func requiresMainQueueSetup() -> Bool {
Expand Down
4 changes: 2 additions & 2 deletions ios/components/RNAddToWalletButtonView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import Foundation
import PassKit
import UIKit

@objc(AddToWalletButtonView)
class AddToWalletButtonView: UIView {
@objc(RNAddToWalletButtonView)
class RNAddToWalletButtonView: UIView {
private var addPassButton = PKAddPassButton(addPassButtonStyle: .blackOutline)
private let defaultWidth: CGFloat = 120
private let defaultHeight: CGFloat = 40
Expand Down