Add white background to SVGs, to fix invisibility in dark mode #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Did you test your solution?
Problem Description
As mentioned in #85, the SVG images are invisible in dark mode. This is because they use a black foreground on a transparent background.
Solution Description
The
\bginstruction does not work with SVG in codecogs, but\colorboxdoes. This PR wraps each expression in a\colorbox. Sox = 2kjbecomes\colorbox{white}{$x = 2kj$}.For future reference, I used a sed oneliner to apply this to all instances:
sed -i -E 's|\]\(http://latex\.codecogs\.com/svg\.latex\?([^)]*)\)|](http://latex.codecogs.com/svg.latex?%5Ccolorbox%7Bwhite%7D%7B%24\1%24%7D)|g' input.mdSide Effects, Risks, Impact
The margin around the expression is slightly increased (in firefox at least). This fixes the dark mode legibility problem that @mwmwmw reported in #86, but in light mode it just means the margins are slightly bigger.