Refactor Javascript and related API functions #2725
Conversation
github-actions
bot
added
payment-gateways
API
extensions
npm
library
modules
admin-panel
labels
admdly
changed the title
There was a problem hiding this comment.
There are a huge amount of file changes in here. I have skimmed the 163 files (that was a slow moving scrollbar) and everything seems logical and nothing jumps out as potentially wrong.
Also nothing seemed obviously broken on a quick test install, so everything seems good to me, and if there are any issues then we should pick them up in the upcoming testing for new release.
Nicely done Adam :)
|
Noticed the change of case to Title Case in a lot of messages. Is that what we are standardising on? I don't mind either way, but do want to make sure we move towards consistency in these. |
I support sticking with Title Case, as I believe it looks better and more professional. I'm sure there's a ton of areas remaining to be updated for consistency though as I only updated things as I noticed it with this PR. |
Remove depreciated and unused JavaScript functions, replacing with `FOSSBilling.*` functions or vanilla JS where appropriate.
Update Javascript API wrapper to use HTML `data` attributes. Also move Javascript API functionality to API wrapper.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This is a fairly comprehensive PR, given the subject matter. I've done some testing, but can't promise to have touched everything in the same way as a pre-release review, though I remain available to fix anything unexpected promptly. 🙂 |
admdly
dismissed
BelleNottelling’s stale review
Substational changes made - new review requested.
3 participants
Modernise JavaScript usage, enhance API interaction patterns, and clean up legacy code. Main theme is update API form handling in Twig templates, improve client-side scripting for payment adapters, and minor dependency and codebase improvement.