Skip to content

Serverbrowser fixes #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a1batross merged 2 commits into from
Feb 7, 2026
+28 −11
Merged

Serverbrowser fixes #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15df35b
ServerBrowser: prevent duplicate entries in Favorites tab
Vladislav4KZ Feb 6, 2026
10c7499
ServerBrowser: parse favorites and history lists only from current ga…
Vladislav4KZ Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 28 additions & 11 deletions menus/ServerBrowser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,22 +966,37 @@ void CMenuServerBrowser::AddServer( void )

// FIXME: for now we can only show custom servers at favorites tab

// Check for duplicates in favorites list
FOR_EACH_VEC( favoritesList, i )
{
if( !strcmp( favoritesList[i].sadr, addressField.GetBuffer() ) &&
!strcmp( favoritesList[i].prot, proto ))
{
UI_ShowMessageBox( L( "Server already in favorites" ));
return;
}
}

favlist_entry_t entry( addressField.GetBuffer(), proto, false );
favoritesList.AddToTail( entry );

if( tabSwitch.GetState() != 2 )
{
tabSwitch.SetState( 2 );
}
else
{
CUtlString fakeInfoString;
entry.GenerateDummyInfoString( fakeInfoString );

CUtlString fakeInfoString;
entry.GenerateDummyInfoString( fakeInfoString );

server_t serv( adr, fakeInfoString, false, true );
serv.UpdateData();
serv.SetPing( MAX_PING );
gameListModel.servers.AddToTail( serv );
server_t serv( adr, fakeInfoString, false, true );
serv.UpdateData();
serv.SetPing( MAX_PING );
gameListModel.servers.AddToTail( serv );

entry.QueryServer();
UI_MenuResetPing_f();
entry.QueryServer();
UI_MenuResetPing_f();
}
}

/*
Expand Down Expand Up @@ -1276,8 +1291,10 @@ void CMenuServerBrowser::Show()

favoritesList.RemoveAll();
historyList.RemoveAll();
ParseServerListFromFile( "favorite_servers.lst", favoritesList );
ParseServerListFromFile( "history_servers.lst", historyList );
if( EngFuncs::FileExists( "favorite_servers.lst", true ) )
ParseServerListFromFile( "favorite_servers.lst", favoritesList );
if( EngFuncs::FileExists( "history_servers.lst", true ) )
ParseServerListFromFile( "history_servers.lst", historyList );
}

RealignButtons();
Expand Down