Adding "setDebugOutput()" Methode to SerialFake#63
Open
JoJos1220 wants to merge 7 commits intoFabioBatSilva:masterfrom
Open
Adding "setDebugOutput()" Methode to SerialFake#63JoJos1220 wants to merge 7 commits intoFabioBatSilva:masterfrom
JoJos1220 wants to merge 7 commits intoFabioBatSilva:masterfrom
Conversation
Owner
|
Thanks @JoJos1220 Can you add a test for the new method please ? If the build passes we are good. |
Author
|
I added a simple test in the serial-basic file. |
Author
|
I need help with the testing part - tried now 4 times wird issues, local testing doesn't work & always waiting until action finish to see if it works or not sucks.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added now the setDebugOutput Methode to the SerialFake file.
As I mentioned, it is not possible to me, testing with Cmake. So this are untested changes which are working for me locally while unit testing within native environment. See #62 .