Draft
Conversation
TheRealQuantam
commented
Jul 21, 2023
| /// <summary> | ||
| /// Buffer for binary data that can read and write individual and series of 8-bit and 16-bit values with automatic endian conversion. | ||
| /// </summary> | ||
| public class BinaryBuffer |
Author
There was a problem hiding this comment.
My BinaryBuffer class from the MM2 Randomizer
TheRealQuantam
commented
Jul 21, 2023
| /// <summary> | ||
| /// FamiTracker module binary class for parsing and modifying FTMs. Mainly used for rebasing and swapping square channels. | ||
| /// </summary> | ||
| public class FtmBinary |
Author
There was a problem hiding this comment.
My FtmBinary class from the MM2 Randomizer
TheRealQuantam
commented
Jul 21, 2023
Author
There was a problem hiding this comment.
Due to the number of changes made, by far the easiest way to deploy the ffft changes is via a patch file.
TheRealQuantam
commented
Jul 21, 2023
Author
There was a problem hiding this comment.
XML format is not really something the FF1 randomizer uses, but I was hoping to keep it that way so that entries can be trivially copied between the MM2 and FF1 randomizers.
Currently contains the Dragon Warrior and FF2/3 soundtracks, but more can be easily added.
TheRealQuantam
commented
Jul 21, 2023
Author
There was a problem hiding this comment.
Move music stuff to its own file for tidiness.
…rite of track names to Debug.Print.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a draft pull request for code review purposes.