-
Notifications
You must be signed in to change notification settings - Fork 466
Add support for Node 24 #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for Node 24 #429
Conversation
Summary of ChangesHello @service-paradis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces compatibility for Node.js 24, aligning the project with Firebase's support for this version. The primary goal is to enable developers to deploy frameworks utilizing Node.js 24, ensuring access to the latest runtime features and performance enhancements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Node.js version 24 to the firebase-frameworks package. The changes correctly update the engines field in package.json and the corresponding package-lock.json. The changes are straightforward and align with the goal of supporting the latest LTS versions of Node.js. The implementation is correct and I see no issues.
leoortizz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @service-paradis! Left a question for @jamesdaniels
| ], | ||
| "engines": { | ||
| "node": "^16.0.0 || ^18.0.0 || ^20.0.0 || ^22.0.0" | ||
| "node": "^16.0.0 || ^18.0.0 || ^20.0.0 || ^22.0.0 || ^24.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we should match firebase-tools and keep only >=20.0.0 || >=22.0.0 || >=24.0.0. @jamesdaniels WDYT?
| "node": "^16.0.0 || ^18.0.0 || ^20.0.0 || ^22.0.0 || ^24.0.0" | |
| "node": ">=20.0.0 || >=22.0.0 || >=24.0.0" |
Closes #425
Firebase supports Node 24. We should be able to deploy frameworks using this version.