Revert "Block builds on vulnerable nextjs versions"

[annajowang]

Reverts #447 while updating the package.json

[gemini-code-assist]

Summary of Changes

Hello @annajowang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change that aimed to block builds on vulnerable Next.js versions. The original implementation, which checked and enforced Next.js version compatibility, has been entirely removed, effectively disabling the build-blocking mechanism. This change streamlines the build process by removing the version validation step.

Highlights

• Reversion of Next.js Version Blocking: This pull request fully reverts the functionality that previously blocked builds when vulnerable Next.js versions were detected, undoing the changes introduced in Block builds on vulnerable nextjs versions #447.
• Dependency Removal: The semver dependency has been removed from the @apphosting/adapter-nextjs package, as it is no longer needed for version checking.
• Code Removal: The checkNextJSVersion utility function, its import, and its invocation in the build process have all been removed, along with its corresponding unit tests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts a previous change that blocked builds on vulnerable Next.js versions. While this is a simple revert, it has significant security implications. My review focuses on the critical risk of removing this security check without clear justification. I've added comments to highlight the removal of the version check logic, the function itself, and its associated tests. It is crucial to understand the reasoning behind this revert to ensure that applications are not exposed to known vulnerabilities.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/@apphosting/adapter-nextjs/src/bin/build.ts (28)

This change removes the call to checkNextJSVersion, which was a security measure to prevent builds with vulnerable Next.js versions. Reverting this check without providing context in the pull request description is a critical security risk, as it could allow known vulnerabilities to be deployed. Please add a detailed explanation for this revert. If the original check was problematic, it should be fixed rather than removed. If this is a temporary change, it should be tracked with an issue to ensure it's reinstated promptly.

packages/@apphosting/adapter-nextjs/src/utils.ts (21-35)

The checkNextJSVersion function, which is responsible for blocking deployments with vulnerable Next.js versions, is being completely removed. This significantly weakens the security posture of the build process. It's highly recommended to retain this security check. If there are issues with its implementation, they should be addressed instead of removing the function entirely.

packages/@apphosting/adapter-nextjs/src/utils.spec.ts (9-61)

Removing the test suite for checkNextJSVersion is a direct consequence of removing the function. This means there is no longer test coverage for the Next.js version vulnerability check. If this security feature is reinstated in the future, these tests should be restored as well.

[annajowang]

Not merging unless things go wrong