Skip to content

BETWEEN Support #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilsonjoanelo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BETWEEN Support #1256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions src/FirebirdSql.EntityFrameworkCore.Firebird/Query/Internal/FbQuerySqlGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,17 +143,23 @@ protected override Expression VisitSqlBinary(SqlBinaryExpression sqlBinaryExpres
Sql.Append(")");
return sqlBinaryExpression;
}
else
else if (sqlBinaryExpression.OperatorType == ExpressionType.AndAlso)
{
return base.VisitSqlBinary(sqlBinaryExpression);
}

void BooleanToIntegralAndVisit(SqlExpression expression)
{
Sql.Append("IIF(");
Visit(expression);
Sql.Append(", 1, 0)");
if (sqlBinaryExpression.Left is SqlBinaryExpression left &&
sqlBinaryExpression.Right is SqlBinaryExpression right &&
left.OperatorType == ExpressionType.GreaterThanOrEqual &&
right.OperatorType == ExpressionType.LessThanOrEqual &&
left.Left.Equals(right.Left))
{
Visit(left.Left);
Sql.Append(" BETWEEN ");
Visit(left.Right);
Sql.Append(" AND ");
Visit(right.Right);
return sqlBinaryExpression;
}
}
return base.VisitSqlBinary(sqlBinaryExpression);
}

protected override Expression VisitSqlParameter(SqlParameterExpression sqlParameterExpression)
Expand Down Expand Up @@ -413,4 +419,11 @@ void GenerateList<T>(IReadOnlyList<T> items, Action<T> generationAction, Action<
generationAction(items[i]);
}
}

void BooleanToIntegralAndVisit(SqlExpression expression)
{
Sql.Append("IIF(");
Visit(expression);
Sql.Append(", 1, 0)");
}
}