Skip to content

Deprecate nthreads kwarg#274

Merged
eloualiche merged 8 commits intoFixedEffects:masterfrom
matthieugomez:patch-12
Jan 30, 2026
Merged

Deprecate nthreads kwarg#274
eloualiche merged 8 commits intoFixedEffects:masterfrom
matthieugomez:patch-12

Conversation

@matthieugomez
Copy link
Member

No description provided.

Removed default value for nthreads and adjusted related logic.
Change default value of double_precision based on method.
Updated version and dependency compatibility for FixedEffects.
Updated fit.jl to remove deprecated nthreads argument and adjust AbstractFixedEffectSolver instantiation.
Clarified the usage of multi-threading in FixedEffectModels.
@matthieugomez matthieugomez changed the title Deprecate nthreads kward Deprecate nthreads kwarg Jan 30, 2026
Removed 'nthreads' from the fit function call parameters.
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.50%. Comparing base (72ca0e0) to head (0fbc200).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/fit.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   96.48%   96.50%   +0.01%     
==========================================
  Files           8        8              
  Lines         655      658       +3     
==========================================
+ Hits          632      635       +3     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eloualiche eloualiche merged commit 89e61c5 into FixedEffects:master Jan 30, 2026
3 of 4 checks passed
@matthieugomez
Copy link
Member Author

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants