-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Annotate DynamoDB schemas with validation code #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 95.32% 95.48% +0.15%
==========================================
Files 79 83 +4
Lines 2673 2767 +94
==========================================
+ Hits 2548 2642 +94
Misses 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9567dee to
959bc8c
Compare
Zaimwa9
previously approved these changes
Jan 5, 2026
Contributor
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with 2 NITs:
- The naming might be quite subjective
- The nested loop could be a low hanging fruit to solve now and buy some tranquility
Zaimwa9
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we annotate DynamoDB schema types to enable their usage with Pydantic, when it's available.
It is now possible to use the document typed dicts with
pydantic.TypeAdapterlike so:The
TypeAdapterwill:uuid.UUIDvalues.datetime.datetimevalues.percentage_allocationhigher than 100.The validation is intended to be used in Core API, when writing documents.
If
pydanticnot present, the schemas can still be used as plain typed dicts, i.e. to annotate data returned from DynamoDB.