-
Notifications
You must be signed in to change notification settings - Fork 2
fix(Monitoring): Serve /metrics on a dedicated port #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyller
commented
Jan 15, 2026
e26be48 to
a131c76
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 95.76% 95.90% +0.14%
==========================================
Files 86 90 +4
Lines 2949 3051 +102
==========================================
+ Hits 2824 2926 +102
Misses 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a131c76 to
c530702
Compare
c530702 to
5b99032
Compare
2d3c1b2 to
da24f69
Compare
khvn26
reviewed
Jan 20, 2026
3b9da61 to
13aba21
Compare
khvn26
reviewed
Jan 20, 2026
Member
khvn26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve once the coverage is sorted.
khvn26
previously approved these changes
Jan 20, 2026
khvn26
reviewed
Jan 20, 2026
khvn26
previously approved these changes
Jan 20, 2026
ae173aa to
85ef049
Compare
khvn26
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce metrics loss under load by serving Prometheus metrics on a dedicated process and port, independent of the main API/task-processor server.
Changes
when_readyhook whenPROMETHEUS_ENABLED=true/metricsendpointThis works in conjunction with:
Contributes to Flagsmith/pulumi#147
Review effort: 2/5