Skip to content

fix(test-tools): Registry state is not properly cleared between tests #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khvn26 merged 1 commit into from
Mar 27, 2025
Merged

fix(test-tools): Registry state is not properly cleared between tests #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/common/test_tools/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ def assert_metric_impl() -> Generator[AssertMetricFixture, None, None]:
registry = prometheus_client.REGISTRY
collectors = [*registry._collector_to_names]

# Reset registry state
for collector in collectors:
if isinstance(collector, MetricWrapperBase):
collector.clear()

def _assert_metric(
*,
name: str,
Expand All @@ -25,10 +30,5 @@ def _assert_metric(

yield _assert_metric

# Reset registry state
for collector in collectors:
if isinstance(collector, MetricWrapperBase):
collector.clear()


assert_metric = pytest.fixture(assert_metric_impl)