♻️ (refactor): noisy dio debug logs on web #67 #76
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyller
reviewed
Jul 7, 2025
Contributor
emyller
left a comment
emyller
left a comment
There was a problem hiding this comment.
@deepraj02 Thanks for the contribution! The fix looks good, though can you please explain the amount of dependency changes? If possible, we'd prefer to handle these in a separate effort.
Contributor
Author
|
only imported the |
Contributor
|
@deepraj02 Nice. Can you please revert then the changes to lock files? I believe they're unrelated with this fix. |
Contributor
Author
|
yeah sure, my bad @emyller |
deepraj02
force-pushed
the
fix-noisy-debug-logs
branch
from
7b1a178 to
016c4e0
Compare
Contributor
Author
|
@emyller done ! |
emyller
approved these changes
Jul 7, 2025
Contributor
|
Thanks @deepraj02! Your fix will be included in our next release of the Flutter client. :) |
Contributor
Author
|
@emyller Sounds great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sendTimeout was being applied to ALL requests, including GET requests which don't have a request body. On the web platform, Dio correctly warns that sendTimeout should only be used with requests that have a body to send.
Fixes :
sendTimeoutproperty in theFlagsmithConfigclass to set it tonullwhen running on web platforms (kIsWeb), ensuring compatibility with environments where timeouts may not be applicable.Logs (before vs after) :
