feat: Add feature_type to FeatureMetadata #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature_type field to FeatureMetadata struct so it can be included in FlagResult. This allows consumers to know whether a feature is STANDARD, MULTIVARIATE, etc. Changes: - Make Feature.feature_type public - Add feature_type: String to FeatureMetadata with default "STANDARD" - Update mappers to populate feature_type from Feature, defaulting to "STANDARD" when the source value is None
matthewelwell
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feature_typefield toFeatureMetadatastruct so it's available inFlagResultFeature.feature_typepublic so it can be accessed by mappers"STANDARD"when the source feature type isNoneThis allows consumers (like edge-proxy-rs) to know whether a feature is STANDARD, MULTIVARIATE, etc. without hardcoding the value.