feature: Allow for i18n for first two pages#5692
Open
ZJvandeWeg wants to merge 6 commits intomainfrom
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5692 +/- ##
==========================================
+ Coverage 76.79% 76.81% +0.01%
==========================================
Files 359 359
Lines 17072 17082 +10
Branches 3999 4000 +1
==========================================
+ Hits 13111 13121 +10
Misses 3961 3961
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fully generated changes by Claude CLI, not ideal for documentation location, but something a subsequent prompt can update.
Move README-i18n.md to docs/contribute/i18n.md and format with proper frontmatter to match other developer documentation pages. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Create v-i18n directive for declarative translations using data-i18n attributes - Update Login.vue and Create.vue to use new data-i18n syntax instead of $t() - Add i18n helper utilities for composition API and dynamic content - Update i18n documentation with new usage patterns and migration guidelines - Improve DX with cleaner templates and better performance - Maintain fallback support for missing translations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- fastify-i18n v3.0.0 requires Fastify v5.x but project uses v4.26.2 - Downgrade to v1.2.0 which is compatible with Fastify v4 - Resolves test failures with "expected '5.x' fastify version" error - Maintains i18n functionality while ensuring test compatibility 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace deprecated directory parameter with messages object to fix Object.entries() error in fastify-i18n v1.2.0. Load locale files manually and use fallbackLocale instead of defaultLocale. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
ZJvandeWeg
force-pushed
the
feature/i18n-implementation
branch
from
e4f3b9b to
82182be
Compare
joepavitt
reviewed
Jul 1, 2025
| validateFormInputs () { | ||
| if (!this.input.username.trim()) { | ||
| this.errors.username = 'Username is required' | ||
| this.errors.username = this.$t('auth.errors.usernameRequired') |
Contributor
There was a problem hiding this comment.
In the same way we have the fallbacks in place for the HTML, should we not also have them here, e.g.:
this.errors.username = this.$t('auth.errors.usernameRequired') || 'username is required'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully generated changes by Claude CLI, not ideal for documentation location, but something a subsequent prompt can update.
Related Issue(s)
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel