Enable number display on UI Gauge Tank widget#1966
Enable number display on UI Gauge Tank widget#1966gemini86 wants to merge 2 commits intoFlowFuse:mainfrom
Conversation
- removed automatic percentage calculation - added options for prefix and suffix display
|
This needs to be conditional, so the user can select % or value, otherwise it will break the dashboard for existing users who expect, and want, a % value. |
I originally did intend to do this but thought it would be worth discussion. Currently, the user is configuring a value type with the typedInput dropdown. If they have configured, EG, |
Absolutely. That is what I assumed would be the case. Then it will display the value (wherever it comes from) as a number or as a percentage of range. |
- enabled by default when gauge type is 'gauge-tank' to mimic original behavior - option is available for all gauge types, but not the default for others
|
pushed some changes which add a checkbox for displaying value as percent- but this is only checked by default for the 'tank' type gauge, others uncheck by default. It would really be my personal preference not to have checkboxes checking and unchecking themselves but if we really see displaying the actual value by default a "breaking change" (subjective I think) then I see no other way around this. |
|
I think it is only when a user has a tank on his dashboard and upgrades to the latest version that the current default must be used, so the display does not change when he upgrades. If a new tank is added then probably it would be ok for it to default to value rather than %. @Steve-Mcl might have thoughts on this though. |
Description
The tank gauge looks so great, yet offers the least flexibility in value rendering. I suggest fixing this.
msg.payloadto a percentage of min/max. The gauge background wave animation already indicates this.Notes:
Related Issue(s)
#1495
#1275
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel