-
-
Notifications
You must be signed in to change notification settings - Fork 23.6k
feat: Add n1n provider #5649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add n1n provider #5649
Conversation
- Add ChatN1n node - Add N1nApi credential - Update models.json with n1n models - Add n1n SVG icon
Summary of ChangesHello @n1n-api, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the n1n provider into Flowise, significantly expanding the platform's chat model capabilities. It introduces the necessary infrastructure for authenticating with n1n API keys, provides a new chat model node for interacting with n1n's language models, and updates the system's model registry to reflect the newly supported models. This enhancement allows users to leverage a broader range of AI services directly within their Flowise applications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for the n1n chat model provider. The changes include adding a new credential type, a new chat model node, and the corresponding model definitions and icon. The implementation correctly follows the existing patterns in the codebase by extending the Langchain OpenAI chat model, which is appropriate for an OpenAI-compatible API. The code is well-structured. I have one minor suggestion to improve code quality.
| import { getBaseClasses, getCredentialData, getCredentialParam } from '../../../src/utils' | ||
| import { ChatN1n } from './FlowiseChatN1n' | ||
| import { getModels, MODEL_TYPE } from '../../../src/modelLoader' | ||
| import { OpenAI as OpenAIClient } from 'openai' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove
This PR adds n1n as a chat model provider to Flowise.
Changes: