fix: resolve missing dependencies for Windows Kafka SASL support #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-stephens
added
the
build-windows
Contributor
Author
|
@cubic-dev-ai please review. |
@patrick-stephens I have started the AI code review. It will take a few minutes to complete. |
patrick-stephens
force-pushed
the
14_oauth_support_windwos
branch
from
11bb98e to
8bac230
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issue)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="source/cmake/kafka.cmake">
<violation number="1" location="source/cmake/kafka.cmake:12">
P1: Rule violated: **Ensure tests are added**
Production code modified without corresponding test changes. The rule requires that changes to production files under `source/` (like `source/cmake/kafka.cmake`) include at least one test file change under `source/tests/` or `source/testing/`. Consider updating `source/tests/runtime/out_kafka.c` or adding a new CMake test to verify:
- Windows SASL enablement when FLB_TLS is on
- FATAL_ERROR behavior when SASL/OAuth Bearer is disabled</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
patrick-stephens
force-pushed
the
14_oauth_support_windwos
branch
from
8bac230 to
03ecde1
Compare
patrick-stephens
force-pushed
the
14_oauth_support_windwos
branch
2 times, most recently
from
383e403 to
7ab765b
Compare
…it push Signed-off-by: Patrick Stephens <pat@fluent.do>
patrick-stephens
force-pushed
the
14_oauth_support_windwos
branch
from
7ab765b to
7c99f6d
Compare
Contributor
Author
|
/build macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14 using techniques from fluent/fluent-bit#11294 although with some fixes.
Summary by cubic
Fix Windows Kafka SASL setup by gating OAuth Bearer on TLS for Windows and failing misconfigured builds. Addresses #14 and avoids hidden dependency issues while aligning with librdkafka behavior on Windows.
Written for commit 7c99f6d. Summary will update automatically on new commits.