Merged
Conversation
🦋 Changeset detectedLatest commit: 3cfe239 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nlkluth
commented
Dec 9, 2024
| grammar, | ||
| language, | ||
| // prism is a stable import | ||
| prism, |
Contributor
Author
There was a problem hiding this comment.
since prism is being imported, it's stable and won't cause unnecessary recalculations. I tested this a bit by changing some state while prism was in the dependency array and the memoized function was not invoked again
carbonrobot
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #251
Type of Change
How Has This Been Tested?
Demo app and a local nextjs app
Checklist: (Feel free to delete this section upon completion)